feat(cdk:popper): upgrade popperjs to floating-ui #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## next #1191 +/- ##
==========================================
- Coverage 96.95% 93.21% -3.74%
==========================================
Files 318 317 -1
Lines 30137 29932 -205
Branches 2785 3452 +667
==========================================
- Hits 29218 27901 -1317
- Misses 919 2031 +1112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danranVm
requested changes
Oct 11, 2022
| @@ -37,7 +37,6 @@ export type PopperTrigger = 'click' | 'hover' | 'focus' | 'contextmenu' | 'manua | |||
| | `show` | 显示浮层 | `(delay?: number): void` | - | - | `delay` 是延迟显示的时间 | | |||
| | `hide` | 隐藏浮层 | `(delay?: number): void` | - | - | `delay` 是延迟隐藏的时间 | | |||
| | `update` | 更新浮层 | `(options: Partial<PopperOptions>): void` | - | - | - | | |||
| | `forceUpdate` | 强制更新浮层 | `(): void` | - | - | - | | |||
sallerli1
force-pushed
the
replace-popper-with-floating-ui-saller
branch
from
2f657ca
to
0a93d6e
Compare
BREAKING CHANGE: forceUpdate is now removed BREAKING CHANGE: modifiers is now changed to middlewares BREAKING CHANGE: onFirstUpdate is now removed
sallerli1
force-pushed
the
replace-popper-with-floating-ui-saller
branch
from
0a93d6e
to
2f2ca12
Compare
danranVm
pushed a commit
that referenced
this pull request
Oct 21, 2022
BREAKING CHANGE: modifiers is now changed to middlewares BREAKING CHANGE: forceUpdate is now removed BREAKING CHANGE: onFirstUpdate is now removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: forceUpdate is now removed
BREAKING CHANGE: modifiers is now changed to middlewares
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
迁移popperjs到floating-ui/dom
修改overlay的箭头样式
Other information
floating-ui没有生命周期的说法，更新同一都是异步，因此移除forceUpdate
floating-ui的middleware与原先的modifier无法兼容，将modifier改为middleware